[SPARK-51659] Add cache and describe-related sql test and answer files
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this PR, @attilapiros ? |
|
Should this be executed by the SQLTests.swift? As that one contains a preprocessor macro checking the os and I think the test executions are skipped because of it: |
|
Yes, the current Github Action CI configuration is unable to cover 'collect' and 'show'-based integration test cases due to the Swift Linux implementation difference, @attilapiros . Those integration test cases should be tested on MacOS-based CI or local Mac for now. |
|
This Linux-related issue has been a known limitation of Arrow Swift implementation so far and I've been working on in seperately. |
attilapiros
approved these changes
Mar 30, 2025
There was a problem hiding this comment.
LGTM.
On Mac the test is running successfully:
◇ Suite SQLTests started.
◇ Test runAll() started.
binary.sql
cache.sql
clear_cache.sql
date.sql
describe_function.sql
describe_query.sql
floating.sql
integral.sql
pipesyntax.sql
select.sql
string.sql
uncache.sql
✔ Test runAll() passed after 0.174 seconds.
✔ Suite SQLTests passed after 0.174 seconds.
|
Thank you so much, @attilapiros . Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add cache and describe related SQL test and answer files.
cache.sqlclear_cache.sqluncache.sqldescribe_function.sqldescribe_query.sqlWhy are the changes needed?
To have a test coverage.
Does this PR introduce any user-facing change?
No, this is a test only change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.